From 2cabe492393ec1511d6b9e2b7377635c9a524127 Mon Sep 17 00:00:00 2001
From: Maschga <88616799+Maschga@users.noreply.github.com>
Date: Wed, 9 Apr 2025 22:57:56 +0200
Subject: [PATCH] chore: Typescript Auth (#20470)

---
 assets/js/api.js                            |   2 +-
 assets/js/components/Auth/LoginModal.vue    |  19 ++--
 assets/js/components/Auth/PasswordModal.vue |   9 +-
 assets/js/components/Auth/auth.js           | 107 -------------------
 assets/js/components/Auth/auth.ts           | 109 ++++++++++++++++++++
 assets/js/components/HelpModal.vue          |   2 +-
 assets/js/components/Top/Navigation.vue     |   2 +-
 assets/js/router.js                         |   2 +-
 assets/js/types/evcc.ts                     |   4 +
 9 files changed, 133 insertions(+), 123 deletions(-)
 delete mode 100644 assets/js/components/Auth/auth.js
 create mode 100644 assets/js/components/Auth/auth.ts

diff --git a/assets/js/api.js b/assets/js/api.js
index 7c8935430..1c52741e9 100644
--- a/assets/js/api.js
+++ b/assets/js/api.js
@@ -1,5 +1,5 @@
 import axios from "axios";
-import { openLoginModal } from "./components/Auth/auth.js";
+import { openLoginModal } from "./components/Auth/auth";
 
 const { protocol, hostname, port, pathname } = window.location;
 
diff --git a/assets/js/components/Auth/LoginModal.vue b/assets/js/components/Auth/LoginModal.vue
index f9ac99947..2227b0884 100644
--- a/assets/js/components/Auth/LoginModal.vue
+++ b/assets/js/components/Auth/LoginModal.vue
@@ -57,14 +57,15 @@
 	</GenericModal>
 </template>
 
-<script>
+<script lang="ts">
 import GenericModal from "../Helper/GenericModal.vue";
 import Modal from "bootstrap/js/dist/modal";
 import api from "../../api.js";
-import { updateAuthStatus, getAndClearNextUrl, getAndClearNextModal, isLoggedIn } from "./auth.js";
+import { updateAuthStatus, getAndClearNextUrl, getAndClearNextModal, isLoggedIn } from "./auth";
 import { docsPrefix } from "../../i18n.js";
+import { defineComponent } from "vue";
 
-export default {
+export default defineComponent({
 	name: "LoginModal",
 	components: { GenericModal },
 	data: () => {
@@ -98,11 +99,11 @@ export default {
 			this.iframeHint = false;
 		},
 		focus() {
-			console.log(this.$refs.password);
-			this.$refs.password.focus();
+			console.log(this.$refs["password"]);
+			this.$refs["password"]?.focus();
 		},
 		closeModal() {
-			Modal.getOrCreateInstance(document.getElementById("loginModal")).hide();
+			Modal.getOrCreateInstance(document.getElementById("loginModal") as HTMLElement).hide();
 		},
 		async login() {
 			this.loading = true;
@@ -136,13 +137,15 @@ export default {
 				}
 			} catch (err) {
 				console.error(err);
-				this.error = err.message;
+				if (err instanceof Error) {
+					this.error = err.message;
+				}
 			} finally {
 				this.loading = false;
 			}
 		},
 	},
-};
+});
 </script>
 <style scoped>
 form {
diff --git a/assets/js/components/Auth/PasswordModal.vue b/assets/js/components/Auth/PasswordModal.vue
index d4b8c3fde..6209bd452 100644
--- a/assets/js/components/Auth/PasswordModal.vue
+++ b/assets/js/components/Auth/PasswordModal.vue
@@ -85,13 +85,14 @@
 	</GenericModal>
 </template>
 
-<script type="js">
+<script type="ts">
 import GenericModal from "../Helper/GenericModal.vue";
 import FormRow from "../Helper/FormRow.vue";
 import api from "../../api.js";
-import { updateAuthStatus, isConfigured } from "./auth.js";
+import { updateAuthStatus, isConfigured } from "./auth";
+import  { defineComponent } from "vue";
 
-export default {
+export default defineComponent({
 	name: "PasswordModal",
 	components: { FormRow, GenericModal },
 	data: () => {
@@ -173,5 +174,5 @@ export default {
 			}
 		},
 	},
-};
+});
 </script>
diff --git a/assets/js/components/Auth/auth.js b/assets/js/components/Auth/auth.js
deleted file mode 100644
index c3891cd79..000000000
--- a/assets/js/components/Auth/auth.js
+++ /dev/null
@@ -1,107 +0,0 @@
-import { reactive, watch } from "vue";
-import api from "../../api.js";
-import store from "../../store.js";
-import Modal from "bootstrap/js/dist/modal";
-import { isSystemError } from "../../utils/fatal.js";
-
-const auth = reactive({
-  configured: true,
-  loggedIn: null, // true / false / null (unknown)
-  nextUrl: null, // url to navigate to after login
-  nextModal: null, // modal instance to show after login
-});
-
-export async function updateAuthStatus() {
-  if (store.state.offline || isSystemError(store.state.fatal)) {
-    // system not ready, skip auth check
-    return;
-  }
-
-  try {
-    const res = await api.get("/auth/status", {
-      validateStatus: (code) => [200, 501, 500].includes(code),
-    });
-    if (res.status === 501) {
-      auth.configured = false;
-    }
-    if (res.status === 200) {
-      auth.configured = true;
-      auth.loggedIn = res.data === true;
-    }
-    if (res.status === 500) {
-      auth.loggedIn = null;
-      console.log("unable to fetch auth status", res);
-    }
-  } catch (e) {
-    console.log("unable to fetch auth status", e);
-  }
-}
-
-export async function logout() {
-  try {
-    await api.post("/auth/logout");
-    await updateAuthStatus();
-    auth.nextUrl = null;
-  } catch (e) {
-    console.log("unable to logout", e);
-  }
-}
-
-export function isLoggedIn() {
-  return auth.loggedIn === true;
-}
-
-export function statusUnknown() {
-  return auth.loggedIn === null;
-}
-
-export function isConfigured() {
-  return auth.configured;
-}
-
-export function getAndClearNextUrl() {
-  const nextUrl = auth.nextUrl;
-  auth.nextUrl = null;
-  return nextUrl;
-}
-
-export function getAndClearNextModal() {
-  const nextModal = auth.nextModal;
-  auth.nextModal = null;
-  return nextModal;
-}
-
-export function openLoginModal(nextUrl = null, nextModal = null) {
-  auth.nextUrl = nextUrl;
-  auth.nextModal = nextModal;
-  const modal = Modal.getOrCreateInstance(document.getElementById("loginModal"));
-  modal.show();
-}
-
-// show/hide password modal based on auth status
-watch(
-  () => auth.configured,
-  (configured) => {
-    console.log("configured", configured);
-    const modal = Modal.getOrCreateInstance(document.getElementById("passwordModal"));
-    if (configured) {
-      modal.hide();
-    } else {
-      modal.show();
-    }
-  }
-);
-
-let timeoutId = null;
-function debounedUpdateAuthStatus() {
-  clearTimeout(timeoutId);
-  timeoutId = setTimeout(() => {
-    updateAuthStatus();
-  }, 500);
-}
-
-// update auth status on reconnect or server restart
-watch(() => store.state.offline, debounedUpdateAuthStatus);
-watch(() => store.state.startup, debounedUpdateAuthStatus);
-
-export default auth;
diff --git a/assets/js/components/Auth/auth.ts b/assets/js/components/Auth/auth.ts
new file mode 100644
index 000000000..da52c04b8
--- /dev/null
+++ b/assets/js/components/Auth/auth.ts
@@ -0,0 +1,109 @@
+import { reactive, watch } from "vue";
+import api from "../../api.js";
+import store from "../../store.js";
+import Modal from "bootstrap/js/dist/modal";
+import { isSystemError } from "../../utils/fatal.js";
+
+const auth = reactive({
+	configured: true,
+	loggedIn: null as boolean | null, // true / false / null (unknown)
+	nextUrl: null as string | null, // url to navigate to after login
+	nextModal: null as Modal | null, // modal instance to show after login
+});
+
+export async function updateAuthStatus() {
+	if (store.state.offline || isSystemError(store.state.fatal)) {
+		// system not ready, skip auth check
+		return;
+	}
+
+	try {
+		const res = await api.get("/auth/status", {
+			validateStatus: (code) => [200, 501, 500].includes(code),
+		});
+		if (res.status === 501) {
+			auth.configured = false;
+		}
+		if (res.status === 200) {
+			auth.configured = true;
+			auth.loggedIn = res.data === true;
+		}
+		if (res.status === 500) {
+			auth.loggedIn = null;
+			console.log("unable to fetch auth status", res);
+		}
+	} catch (e) {
+		console.log("unable to fetch auth status", e);
+	}
+}
+
+export async function logout() {
+	try {
+		await api.post("/auth/logout");
+		await updateAuthStatus();
+		auth.nextUrl = null;
+	} catch (e) {
+		console.log("unable to logout", e);
+	}
+}
+
+export function isLoggedIn() {
+	return auth.loggedIn === true;
+}
+
+export function statusUnknown() {
+	return auth.loggedIn === null;
+}
+
+export function isConfigured() {
+	return auth.configured;
+}
+
+export function getAndClearNextUrl() {
+	const nextUrl = auth.nextUrl;
+	auth.nextUrl = null;
+	return nextUrl;
+}
+
+export function getAndClearNextModal() {
+	const nextModal = auth.nextModal;
+	auth.nextModal = null;
+	return nextModal;
+}
+
+export function openLoginModal(nextUrl = null, nextModal = null) {
+	auth.nextUrl = nextUrl;
+	auth.nextModal = nextModal;
+	const modal = Modal.getOrCreateInstance(document.getElementById("loginModal") as HTMLElement);
+	modal.show();
+}
+
+// show/hide password modal based on auth status
+watch(
+	() => auth.configured,
+	(configured) => {
+		console.log("configured", configured);
+		const modal = Modal.getOrCreateInstance(
+			document.getElementById("passwordModal") as HTMLElement
+		);
+		if (configured) {
+			modal.hide();
+		} else {
+			modal.show();
+		}
+	}
+);
+
+let timeoutId: number | undefined = undefined;
+function debounedUpdateAuthStatus() {
+	clearTimeout(timeoutId);
+	timeoutId = setTimeout(() => {
+		updateAuthStatus();
+	}, 500);
+}
+
+// update auth status on reconnect or server restart
+watch(() => store.state.offline, debounedUpdateAuthStatus);
+watch(() => store.state.startup, debounedUpdateAuthStatus);
+
+export default auth;
diff --git a/assets/js/components/HelpModal.vue b/assets/js/components/HelpModal.vue
index 4781ea6f2..dd952e6b5 100644
--- a/assets/js/components/HelpModal.vue
+++ b/assets/js/components/HelpModal.vue
@@ -140,7 +140,7 @@
 import Modal from "bootstrap/js/dist/modal";
 import { docsPrefix } from "../i18n.js";
 import { performRestart } from "../restart.js";
-import { isLoggedIn, openLoginModal } from "./Auth/auth.js";
+import { isLoggedIn, openLoginModal } from "./Auth/auth";
 
 export default {
 	name: "HelpModal",
diff --git a/assets/js/components/Top/Navigation.vue b/assets/js/components/Top/Navigation.vue
index 926b44257..bbcbd061d 100644
--- a/assets/js/components/Top/Navigation.vue
+++ b/assets/js/components/Top/Navigation.vue
@@ -131,7 +131,7 @@ import "@h2d2/shopicons/es/regular/moonstars";
 import "@h2d2/shopicons/es/regular/menu";
 import "@h2d2/shopicons/es/regular/newtab";
 import collector from "../../mixins/collector.js";
-import { logout, isLoggedIn, openLoginModal } from "../Auth/auth.js";
+import { logout, isLoggedIn, openLoginModal } from "../Auth/auth";
 import baseAPI from "./baseapi.js";
 import { isApp, sendToApp } from "../../utils/native.js";
 import { isUserConfigError } from "../../utils/fatal.js";
diff --git a/assets/js/router.js b/assets/js/router.js
index f8cceab11..6c06ed48c 100644
--- a/assets/js/router.js
+++ b/assets/js/router.js
@@ -7,7 +7,7 @@ import {
   updateAuthStatus,
   isLoggedIn,
   isConfigured,
-} from "./components/Auth/auth.js";
+} from "./components/Auth/auth";
 
 function hideAllModals() {
   [...document.querySelectorAll(".modal.show")].forEach((modal) => {
diff --git a/assets/js/types/evcc.ts b/assets/js/types/evcc.ts
index 787f14e91..2b3a6f336 100644
--- a/assets/js/types/evcc.ts
+++ b/assets/js/types/evcc.ts
@@ -8,9 +8,13 @@ declare global {
 
 export interface State {
 	offline: boolean;
+	startup?: boolean;
 	loadpoints: [];
 	forecast?: any;
 	currency?: CURRENCY;
+	fatal?: {
+		error: any;
+	};
 }
 
 export enum CURRENCY {