From 422433f5b4e5cc07439200e72e8d95fd025f8fc3 Mon Sep 17 00:00:00 2001
From: Carsten Schlipf <carsten.schlipf@gmail.com>
Date: Mon, 19 Feb 2024 12:08:14 +0100
Subject: [PATCH] Sofarsolar-g3: remove delay (#12341)

---
 templates/definition/meter/sofarsolar-g3.yaml | 21 ++-----------------
 1 file changed, 2 insertions(+), 19 deletions(-)

diff --git a/templates/definition/meter/sofarsolar-g3.yaml b/templates/definition/meter/sofarsolar-g3.yaml
index f333d51ce..af0ca1e8e 100644
--- a/templates/definition/meter/sofarsolar-g3.yaml
+++ b/templates/definition/meter/sofarsolar-g3.yaml
@@ -15,8 +15,8 @@ products:
 # capabilities: ["battery-control"]
 requirements:
   description:
-    de: Es wird dringend empfohlen die Verbindung über einen LSE-3 Logger Stick herzustellen. Andere Verbindungswege (z.B. LSW-3 oder via RS485) sind u.U. instabil und benötigen Verzögerungen (delay) > 0s.
-    en: It is strongly recommended to connect via an LSE-3 logger stick. Other connection paths (e.g. LSW-3 or via RS485) may be unstable and require delays > 0s.
+    de: Es wird empfohlen die Verbindung über einen LSE-3 Logger Stick mittels ModBus TCP herzustellen. Bei seriellem Anschluss via RS485 mit entsprechendem Adapter am COM Port ist zu beachten, dass wechselrichterseitig für eine Terminierung des RS485 Busses zu sorgen ist.
+    en: It is recommended to establish the connection via a LSE-3 logger stick using ModBus TCP. If you are connecting via serial RS485 using the inverter's COM port and a proper adapter note that on the inverter's side you have to take care of a proper termination of the RS485 bus.
 params:
   - name: usage
     choice: ["grid", "pv", "battery"]
@@ -24,9 +24,6 @@ params:
     choice: ["tcpip", "rs485"]
     port: 8899
     id: 1
-  - name: delay
-    default: 0s
-    advanced: true
   - name: capacity
     advanced: true
   # battery control
@@ -42,7 +39,6 @@ render: |
   power:
     source: modbus
     {{- include "modbus" . | indent 2 }}
-    delay: {{ .delay }}
     register:
       address: 0x0488 # ActivePower_PCC_Total
       type: holding
@@ -51,7 +47,6 @@ render: |
   currents:
   - source: modbus
     {{- include "modbus" . | indent 2 }}
-    delay: {{ .delay }}
     register:
       address: 0x0492 # Current_PCC_R
       type: holding
@@ -59,7 +54,6 @@ render: |
     scale: 0.01
   - source: modbus
     {{- include "modbus" . | indent 2 }}
-    delay: {{ .delay }}
     register:
       address: 0x049D # Current_PCC_S
       type: holding
@@ -67,7 +61,6 @@ render: |
     scale: 0.01
   - source: modbus
     {{- include "modbus" . | indent 2 }}
-    delay: {{ .delay }}
     register:
       address: 0x04A8 # Current_PCC_T
       type: holding
@@ -76,7 +69,6 @@ render: |
   powers:
   - source: modbus
     {{- include "modbus" . | indent 2 }}
-    delay: {{ .delay }}
     register:
       address: 0x0493 # ActivePower_PCC_R
       type: holding
@@ -84,7 +76,6 @@ render: |
     scale: -10
   - source: modbus
     {{- include "modbus" . | indent 2 }}
-    delay: {{ .delay }}
     register:
       address: 0x049E # ActivePower_PCC_S
       type: holding
@@ -92,7 +83,6 @@ render: |
     scale: -10
   - source: modbus
     {{- include "modbus" . | indent 2 }}
-    delay: {{ .delay }}
     register:
       address: 0x04A9 # ActivePower_PCC_T
       type: holding
@@ -101,7 +91,6 @@ render: |
   energy:
     source: modbus
     {{- include "modbus" . | indent 2 }}
-    delay: {{ .delay }}
     register:
       address: 0x068E # Energy_Purchase_Total
       type: holding
@@ -112,7 +101,6 @@ render: |
   power:
     source: modbus
     {{- include "modbus" . | indent 2 }}
-    delay: {{ .delay }}
     register:
       address: 0x05C4 # Power_PV_Total
       type: holding
@@ -121,7 +109,6 @@ render: |
   energy:
     source: modbus
     {{- include "modbus" . | indent 2 }}
-    delay: {{ .delay }}
     register:
       address: 0x0686 # PV_Generation_Total
       type: holding
@@ -132,7 +119,6 @@ render: |
   power:
     source: modbus
     {{- include "modbus" . | indent 2 }}
-    delay: {{ .delay }}
     register:
       address: 0x0606 # Power_Bat1
       type: holding
@@ -141,7 +127,6 @@ render: |
   energy:
     source: modbus
     {{- include "modbus" . | indent 2 }}
-    delay: {{ .delay }}
     register:
       address: 0x069A # Bat_Discharge_Total
       type: holding
@@ -150,7 +135,6 @@ render: |
   soc:
     source: modbus
     {{- include "modbus" . | indent 2 }}
-    delay: {{ .delay }}
     register:
       address: 0x0608 # SOC_Bat1
       type: holding
@@ -165,7 +149,6 @@ render: |
   #     config:
   #       source: modbus
   #       {- include "modbus" . | indent 6 }
-  #       delay: { .delay }
   #       register:
   #         address: 0x104D # BatConfig_Depth_of_Discharge
   #         type: writemultiple