Stefan/evcc-io
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

EU Data Act: skip optional marketing consent page after login (#30956)

Browse source
This commit is contained in:
andig 2026-06-17 13:10:17 +02:00 • committed by GitHub
parent 11f7ef5185
commit 52562d9186
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 18 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
vehicle/vag/vwidentity/endpoint.go
View file

@ -194,11 +194,11 @@ func (v *Service) loginLegacy(vars FormVars, user, password string) (url.Values,
return parseAuthLocation(parsed)
}
// marketingConsentCallback returns the OIDC callback url embedded in an
// MarketingConsentCallback returns the OIDC callback url embedded in an
// optional VW/Audi marketing consent page. VW periodically interjects this
// page (path .../consent/marketing/...) after an otherwise successful login.
// It returns a nil url if u is not a marketing consent page.
func marketingConsentCallback(u *url.URL) (*url.URL, error) {
func MarketingConsentCallback(u *url.URL) (*url.URL, error) {
if u == nil || !strings.Contains(u.Path, "/consent/marketing/") {
return nil, nil
}
@ -227,7 +227,7 @@ func (v *Service) skipMarketingConsent(resp *http.Response) (*url.URL, bool, err
return nil, false, nil
}
cb, err := marketingConsentCallback(resp.Request.URL)
cb, err := MarketingConsentCallback(resp.Request.URL)
if err != nil {
return nil, true, err
}

16
vehicle/vw/eudataact/api.go
View file

@ -188,9 +188,23 @@ func (v *API) login() error {
return errors.New(resp.Status)
}
final := resp.Request.URL
// VW periodically interjects an optional marketing consent page after an
// otherwise successful login. Skip it without consenting (#29760).
if cb, err := vwidentity.MarketingConsentCallback(final); err != nil {
return err
} else if cb != nil {
resp, err = v.Get(cb.String())
if err != nil {
return err
}
resp.Body.Close()
final = resp.Request.URL
}
// a successful login lands on the portal; a remaining signin/consent url means
// the user has not completed the one-time browser consent and vehicle linking
final := resp.Request.URL
if strings.Contains(final.Path, "signin-service") || strings.Contains(final.Path, "/consent") || strings.Contains(final.Path, "/error") {
return api.UrlError(
fmt.Sprintf("login did not complete- open the portal and confirm consent: %s", final),