Stefan/evcc-io
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Loadpoint: fix config error for disabled loadpoints (#32923)

Browse source
This commit is contained in:
Michael Geers 2026-08-17 15:25:12 +02:00 • committed by GitHub
parent d1b1ded0e6
commit 52c0cfaa5d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 21 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
server/http_config_loadpoint_handler.go
View file

@ -13,6 +13,7 @@ import (
"github.com/evcc-io/evcc/util"
"github.com/evcc-io/evcc/util/config"
"github.com/evcc-io/evcc/util/templates"
"github.com/go-viper/mapstructure/v2"
"github.com/gorilla/mux"
)
@ -119,8 +120,9 @@ func loadpointConfig(dev config.Device[loadpoint.API]) (loadpointFullConfig, err
return loadpointFullConfig{}, err
}
// non-strict: runtime settings (mode, ...) are persisted alongside the config
var static loadpoint.StaticConfig
if err := util.DecodeOther(staticMap, &static); err != nil {
if err := mapstructure.Decode(staticMap, &static); err != nil {
return loadpointFullConfig{}, err
}

1
server/http_config_loadpoint_handler_test.go
View file

@ -25,6 +25,7 @@ func TestLoadpointConfigDisabledNilInstance(t *testing.T) {
"charger": "wallbox",
"meter": "lp-meter",
"title": "Garage",
"mode": "pv", // runtime setting persisted by the settings adapter
},
}

18
tests/config-disable.spec.ts
View file

@ -59,6 +59,21 @@ test.describe("disable / enable", async () => {
await page.reload();
await createLoadpoint(page, "Garage");
// restart to bring both loadpoints live
await restart();
await page.reload();
// switch charge mode on dashboard; runtime setting is persisted next to the loadpoint config
await page.goto("/");
const modeButton = page
.getByTestId("loadpoint")
.nth(0)
.getByTestId("mode")
.getByRole("button", { name: "Fast" });
await modeButton.click();
await expect(modeButton).toHaveClass(/active/);
await page.goto("/#/config");
const target = page.getByTestId("loadpoint").nth(0);
await toggleLoadpointDisable(page, 0, "Disable");
@ -66,10 +81,11 @@ test.describe("disable / enable", async () => {
// card shows disabled state
await expect(disabledBadge(target)).toBeVisible();
// restart, no fatal
// restart, no fatal, both loadpoints still listed
await restart();
await page.reload();
await expectNoFatal(page);
await expect(page.getByTestId("loadpoint")).toHaveCount(2);
await expect(disabledBadge(target)).toBeVisible();
// re-enable by clicking the disabled card