From 82d332dfb12708fb6a95dbd8fda34768935993ed Mon Sep 17 00:00:00 2001 From: andig Date: Sat, 4 Jul 2026 14:18:27 +0200 Subject: [PATCH] chore: don't fake-deprecate wakeupdisabled on templates that never had it offline/iso15118 never offered wakeupdisabled, so declaring it deprecated there was wrong. Keep it in onlineVehicleFeatures and only check it where a template actually declares the param. --- templates/definition/vehicle/iso15118.yaml | 2 -- templates/definition/vehicle/offline.yaml | 2 -- vehicle/template_test.go | 5 +++++ 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/templates/definition/vehicle/iso15118.yaml b/templates/definition/vehicle/iso15118.yaml index 1b7479f3e..3e44b5e06 100644 --- a/templates/definition/vehicle/iso15118.yaml +++ b/templates/definition/vehicle/iso15118.yaml @@ -22,8 +22,6 @@ params: deprecated: true - name: autodetectdisabled deprecated: true - - name: wakeupdisabled - deprecated: true render: | type: custom {{ include "vehicle-common" . }} diff --git a/templates/definition/vehicle/offline.yaml b/templates/definition/vehicle/offline.yaml index 509704b46..6437c90e2 100644 --- a/templates/definition/vehicle/offline.yaml +++ b/templates/definition/vehicle/offline.yaml @@ -16,8 +16,6 @@ params: deprecated: true - name: autodetectdisabled deprecated: true - - name: wakeupdisabled - deprecated: true render: | type: custom {{- include "vehicle-common" . }} diff --git a/vehicle/template_test.go b/vehicle/template_test.go index 69f4337f8..846d796e5 100644 --- a/vehicle/template_test.go +++ b/vehicle/template_test.go @@ -53,6 +53,11 @@ func TestVehicleFeatureParamsConsistent(t *testing.T) { } for _, feat := range onlineVehicleFeatures { + // not every template ever offered every feature (e.g. wakeupdisabled is new) + if i, _ := tmpl.ParamByName(feat); i < 0 { + continue + } + values := tmpl.Defaults(templates.RenderModeUnitTest) values["template"] = tmpl.Template values[feat] = true