Vehicle: restore streaming param on EU Data Act templates (#31970)
This commit is contained in:
parent
7a95266a6b
commit
90fc0bc71b
6 changed files with 26 additions and 1 deletions
|
|
@ -34,6 +34,8 @@ params:
|
|||
- name: welcomecharge
|
||||
advanced: true
|
||||
deprecated: true
|
||||
- name: streaming
|
||||
deprecated: true
|
||||
- preset: vehicle-online
|
||||
render: |
|
||||
type: drivesomethinggreater
|
||||
|
|
|
|||
|
|
@ -52,6 +52,8 @@ params:
|
|||
- name: welcomecharge
|
||||
advanced: true
|
||||
deprecated: true
|
||||
- name: streaming
|
||||
deprecated: true
|
||||
- preset: vehicle-online
|
||||
render: |
|
||||
type: drivesomethinggreater
|
||||
|
|
|
|||
|
|
@ -30,6 +30,8 @@ params:
|
|||
- name: welcomecharge
|
||||
advanced: true
|
||||
deprecated: true
|
||||
- name: streaming
|
||||
deprecated: true
|
||||
- preset: vehicle-online
|
||||
render: |
|
||||
type: drivesomethinggreater
|
||||
|
|
|
|||
|
|
@ -31,6 +31,8 @@ params:
|
|||
- name: welcomecharge
|
||||
advanced: true
|
||||
deprecated: true
|
||||
- name: streaming
|
||||
deprecated: true
|
||||
- preset: vehicle-online
|
||||
render: |
|
||||
type: drivesomethinggreater
|
||||
|
|
|
|||
|
|
@ -39,6 +39,8 @@ params:
|
|||
- name: welcomecharge
|
||||
advanced: true
|
||||
deprecated: true
|
||||
- name: streaming
|
||||
deprecated: true
|
||||
- preset: vehicle-online
|
||||
render: |
|
||||
type: drivesomethinggreater
|
||||
|
|
|
|||
|
|
@ -1,6 +1,7 @@
|
|||
package vehicle
|
||||
|
||||
import (
|
||||
"slices"
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
|
|
@ -44,7 +45,18 @@ func TestTemplates(t *testing.T) {
|
|||
|
||||
// onlineVehicleFeatures render via the shared vehicle-features include, so a
|
||||
// stored config may carry them; dropping the param breaks reload (discussion #31291).
|
||||
var onlineVehicleFeatures = []string{"climaterdisabled", "autodetectdisabled", "wakeupdisabled"}
|
||||
var onlineVehicleFeatures = []string{"streaming", "coarsecurrent", "welcomecharge", "climaterdisabled", "autodetectdisabled", "wakeupdisabled"}
|
||||
|
||||
// requiredFeatureParams lists features these templates once offered as user
|
||||
// params. Stored configs carry the key, so undeclaring it makes evcc fail to
|
||||
// boot on the next restart (#31962). Deprecate such params, never remove them.
|
||||
var requiredFeatureParams = map[string][]string{
|
||||
"vw": {"streaming", "coarsecurrent", "welcomecharge"},
|
||||
"audi": {"streaming", "coarsecurrent", "welcomecharge"},
|
||||
"seat": {"streaming", "coarsecurrent", "welcomecharge"},
|
||||
"seat-cupra": {"streaming", "coarsecurrent", "welcomecharge"},
|
||||
"drivesomethinggreater": {"streaming", "coarsecurrent", "welcomecharge"},
|
||||
}
|
||||
|
||||
func TestVehicleFeatureParamsConsistent(t *testing.T) {
|
||||
for _, tmpl := range templates.ByClass(templates.Vehicle, templates.WithDeprecated()) {
|
||||
|
|
@ -55,6 +67,9 @@ func TestVehicleFeatureParamsConsistent(t *testing.T) {
|
|||
for _, feat := range onlineVehicleFeatures {
|
||||
// not every template ever offered every feature (e.g. wakeupdisabled is new)
|
||||
if i, _ := tmpl.ParamByName(feat); i < 0 {
|
||||
if slices.Contains(requiredFeatureParams[tmpl.Template], feat) {
|
||||
t.Errorf("%s: feature %q must stay a declared param", tmpl.Template, feat)
|
||||
}
|
||||
continue
|
||||
}
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue