Shelly: drop grid energy and returnEnergy for 3-phase EM (#30534)

meter/shelly.go

@@ -14,7 +14,7 @@ import (
 // Shelly meter considering usage
 type Shelly struct {
 	implement.Caps
-	shelly.Connection
+	conn  *shelly.Connection
 	usage string
 }
 
@@ -45,7 +45,14 @@ func NewShellyFromConfig(other map[string]any) (api.Meter, error) {
 		return nil, err
 	}
 
-	if phases, ok := c.Connection.Generation.(shelly.Phases); ok {
+	// Three-phase Shelly energy meters count each phase separately (non-balanced),
+	// making their totals unsuitable for bidirectional grid metering.
+	if !(c.usage == "grid" && c.conn.IsThreePhase()) {
+		implement.Has(c, implement.MeterEnergy(c.conn.TotalEnergy))
+		implement.Has(c, implement.MeterReturnEnergy(c.conn.ReturnEnergy))
+	}
+
+	if phases, ok := c.conn.Generation.(shelly.Phases); ok {
 		implement.Has(c, implement.PhaseVoltages(phases.Voltages))
 		implement.Has(c, implement.PhaseCurrents(phases.Currents))
 		implement.Has(c, implement.PhasePowers(phases.Powers))
@@ -61,9 +68,9 @@ func NewShelly(uri, user, password, usage string, channel int, cache time.Durati
 		return nil, err
 	}
 	c := &Shelly{
-		Caps:       implement.New(),
-		Connection: *conn,
-		usage:      usage,
+		Caps:  implement.New(),
+		conn:  conn,
+		usage: usage,
 	}
 	return c, nil
 }
@@ -72,7 +79,7 @@ var _ api.Meter = (*Shelly)(nil)
 
 // CurrentPower implements the api.Meter interface
 func (c *Shelly) CurrentPower() (float64, error) {
-	power, err := c.Connection.CurrentPower()
+	power, err := c.conn.CurrentPower()
 	if err != nil {
 		return 0, err
 	}

meter/shelly/connection.go

@@ -18,6 +18,7 @@ type Generation interface {
 	api.Meter
 	api.MeterEnergy
 	api.MeterReturnEnergy
+	IsThreePhase() bool
 }
 
 type Phases interface {

meter/shelly/gen1.go

@@ -144,6 +144,12 @@ func (c *gen1) ReturnEnergy() (float64, error) {
 	return c.energy(energy) / 1000, nil
 }
 
+// IsThreePhase reports whether the device is a three-phase energy meter.
+func (c *gen1) IsThreePhase() bool {
+	res, err := c.status.Get()
+	return err == nil && len(res.EMeters) == 3
+}
+
 // gen1Energy in kWh
 func (c *gen1) energy(energy float64) float64 {
 	// Gen 1 Shelly EM devices are providing Watt hours, Gen 1 Shelly PM devices are providing Watt minutes

meter/shelly/gen2.go

@@ -332,6 +332,11 @@ func (c *gen2) hasEMEndpoint() bool {
 	return c.hasMethod("EM.GetStatus")
 }
 
+// IsThreePhase reports whether the device is a three-phase energy meter
+func (c *gen2) IsThreePhase() bool {
+	return c.hasEMEndpoint()
+}
+
 // Gen2+ models using EM1.GetStatus endpoint for power and EM1Data.GetStatus for energy
 // https://shelly-api-docs.shelly.cloud/gen2/ComponentsAndServices/EM1#em1getstatus-example
 // https://shelly-api-docs.shelly.cloud/gen2/ComponentsAndServices/EM1Data#em1datagetstatus-example