Stefan/evcc-io
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Config UI: fix decimal input in numeric fields (#32458)

Browse source
This commit is contained in:
Michael Geers 2026-08-03 08:51:14 +02:00 • committed by GitHub
parent c4daf8e866
commit bfba6bb2fc
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 47 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
assets/js/components/Config/PropertyField.vue
View file

@ -252,7 +252,7 @@ export default {
},
useLazyBinding() {
// avoid conversion loop issues
return this.pricePerKWh;
return this.inputType === "number";
},
icons() {
return this.property === "icon";
@ -386,6 +386,8 @@ export default {
return val;
},
onFieldChange(e) {
// unparsable input (e.g. locale decimal separator mismatch)
if (e.target.validity?.badInput) return;
this.value = this.coerceValue(e.target.value);
},
onFieldInput(e) {

44
tests/config-decimal-input.spec.ts Normal file
View file

@ -0,0 +1,44 @@
import { test, expect } from "@playwright/test";
import { start, stop, baseUrl } from "./evcc";
import { expectModalVisible } from "./utils";
// German browser language (comma as decimal separator), English UI
// macOS Chromium reads --lang, Linux reads LC_ALL/LANG
test.use({
baseURL: baseUrl(),
launchOptions: {
args: ["--lang=de-DE"],
env: { ...process.env, LC_ALL: "de_DE.UTF-8", LANG: "de_DE.UTF-8" },
},
locale: "en-US",
});
test.beforeAll(async () => {
await start();
});
test.afterAll(async () => {
await stop();
});
test("decimal input with german separator", async ({ page }) => {
await page.goto("/#/config");
await page.getByRole("button", { name: "Add solar or battery" }).click();
const modal = page.getByTestId("meter-modal");
await expectModalVisible(modal);
await modal.getByRole("button", { name: "Add solar meter" }).click();
await modal.getByLabel("Manufacturer").selectOption({ label: "SunSpec Inverter" });
await modal.getByRole("button", { name: "Show advanced settings" }).click();
// comma accepted as decimal separator
const timeout = modal.getByLabel("Timeout");
await timeout.pressSequentially("0,5");
await expect(timeout).toHaveValue("0.5");
// intermediate zeros survive typing
const delay = modal.getByLabel("Delay");
await delay.pressSequentially("0.004");
await expect(delay).toHaveValue("0.004");
await delay.blur();
await expect(delay).toHaveValue("0.004");
});