Stefan/evcc-io
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Onboarding: improve password flow (#27246)

Browse source
This commit is contained in:
Michael Geers 2026-02-06 10:37:42 +01:00 • committed by GitHub
parent 848043e8bb
commit d5df743d8a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 27 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

38
server/http_auth.go
View file

@ -55,6 +55,13 @@ func updatePasswordHandler(authObject auth.Auth) http.HandlerFunc {
http.Error(w, err.Error(), http.StatusInternalServerError)
return
}
// auto-login: set auth cookie
if err := setAuthCookie(authObject, w); err != nil {
http.Error(w, "Failed to generate JWT token.", http.StatusInternalServerError)
return
}
w.WriteHeader(http.StatusCreated)
}
}
@ -103,6 +110,24 @@ func authStatusHandler(authObject auth.Auth) http.HandlerFunc {
}
}
func setAuthCookie(authObject auth.Auth, w http.ResponseWriter) error {
lifetime := time.Hour * 24 * 90 // 90 day valid
tokenString, err := authObject.GenerateJwtToken(lifetime)
if err != nil {
return err
}
http.SetCookie(w, &http.Cookie{
Name: authCookieName,
Value: tokenString,
Path: "/",
HttpOnly: true,
Expires: time.Now().Add(lifetime),
SameSite: http.SameSiteStrictMode,
})
return nil
}
func loginHandler(authObject auth.Auth) http.HandlerFunc {
return func(w http.ResponseWriter, r *http.Request) {
if authObject.GetAuthMode() == auth.Locked {
@ -121,21 +146,10 @@ func loginHandler(authObject auth.Auth) http.HandlerFunc {
return
}
lifetime := time.Hour * 24 * 90 // 90 day valid
tokenString, err := authObject.GenerateJwtToken(lifetime)
if err != nil {
if err := setAuthCookie(authObject, w); err != nil {
http.Error(w, "Failed to generate JWT token.", http.StatusInternalServerError)
return
}
http.SetCookie(w, &http.Cookie{
Name: authCookieName,
Value: tokenString,
Path: "/",
HttpOnly: true,
Expires: time.Now().Add(lifetime),
SameSite: http.SameSiteStrictMode,
})
}
}

9
tests/config-onboarding.spec.ts
View file

@ -29,14 +29,7 @@ test.describe("onboarding", async () => {
await expect(page.locator("body")).toContainText("Hello aboard!");
await page.getByRole("link", { name: "Let's start configuration" }).click();
// login
const login = page.getByTestId("login-modal");
await expectModalVisible(login);
await login.getByLabel("Administrator Password").fill(PASSWORD);
await login.getByRole("button", { name: "Login" }).click();
await expectModalHidden(login);
// config page
// config page (already logged in from password creation)
await expect(page.getByRole("heading", { name: "Configuration" })).toBeVisible();
await expect(page.getByTestId("welcome-banner")).toBeVisible();
await expect(page.getByTestId("welcome-banner")).toContainText("Start with creating a");