From de60dab87962077ca44ec032fbd3fd1bb880294b Mon Sep 17 00:00:00 2001 From: andig Date: Thu, 29 Feb 2024 14:43:05 +0100 Subject: [PATCH] Ignore errors reading PV meter (#12564) --- core/site.go | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/core/site.go b/core/site.go index 81487ea19..2d4e82ee1 100644 --- a/core/site.go +++ b/core/site.go @@ -400,9 +400,9 @@ func (site *Site) publishDelta(key string, val interface{}) { } // updatePvMeters updates pv meters. All measurements are optional. -func (site *Site) updatePvMeters() error { +func (site *Site) updatePvMeters() { if len(site.pvMeters) == 0 { - return nil + return } var totalEnergy float64 @@ -421,8 +421,7 @@ func (site *Site) updatePvMeters() error { site.log.WARN.Printf("pv %d power: %.0fW is negative - check configuration if sign is correct", i+1, power) } } else { - // power is required- return on error - return fmt.Errorf("pv %d power: %v", i+1, err) + site.log.ERROR.Printf("pv %d power: %v", i+1, err) } // pv energy (production) @@ -446,8 +445,6 @@ func (site *Site) updatePvMeters() error { site.publish(keys.PvPower, site.pvPower) site.publish(keys.PvEnergy, totalEnergy) site.publish(keys.Pv, mm) - - return nil } // updateBatteryMeters updates battery meters. Power is retried, other measurements are optional. @@ -595,9 +592,7 @@ func (site *Site) updateGridMeter() error { // updateMeter updates and publishes single meter func (site *Site) updateMeters() error { // TODO parallelize once modbus supports that - if err := site.updatePvMeters(); err != nil { - return err - } + site.updatePvMeters() if err := site.updateBatteryMeters(); err != nil { return err }