package core import ( "testing" "time" evbus "github.com/asaskevich/EventBus" "github.com/benbjohnson/clock" "github.com/evcc-io/evcc/api" "github.com/evcc-io/evcc/core/soc" "github.com/evcc-io/evcc/mock" "github.com/evcc-io/evcc/push" "github.com/evcc-io/evcc/util" "github.com/golang/mock/gomock" "github.com/stretchr/testify/assert" ) const ( minA float64 = 6 maxA float64 = 16 ) type Null struct{} func (n *Null) CurrentPower() (float64, error) { return 0, nil } func (n *Null) ChargedEnergy() (float64, error) { return 0, nil } func (n *Null) ChargingTime() (time.Duration, error) { return 0, nil } func createChannels(t *testing.T) (chan util.Param, chan push.Event, chan *Loadpoint) { uiChan := make(chan util.Param) pushChan := make(chan push.Event) lpChan := make(chan *Loadpoint) log := false go func() { for { select { case v := <-uiChan: if log { t.Log(v) } case v := <-pushChan: if log { t.Log(v) } case v := <-lpChan: if log { t.Log(v) } } } }() return uiChan, pushChan, lpChan } func attachChannels(lp *Loadpoint, uiChan chan util.Param, pushChan chan push.Event, lpChan chan *Loadpoint) { lp.uiChan = uiChan lp.pushChan = pushChan lp.lpChan = lpChan } func attachListeners(t *testing.T, lp *Loadpoint) { Voltage = 230 // V if charger, ok := lp.charger.(*mock.MockCharger); ok && charger != nil { charger.EXPECT().Enabled().Return(true, nil) charger.EXPECT().MaxCurrent(int64(lp.MinCurrent)).Return(nil) } uiChan, pushChan, lpChan := createChannels(t) lp.Prepare(uiChan, pushChan, lpChan) } func TestNew(t *testing.T) { lp := NewLoadpoint(util.NewLogger("foo")) if lp.phases != 0 { t.Errorf("Phases %v", lp.phases) } if lp.MinCurrent != minA { t.Errorf("MinCurrent %v", lp.MinCurrent) } if lp.MaxCurrent != maxA { t.Errorf("MaxCurrent %v", lp.MaxCurrent) } if lp.status != api.StatusNone { t.Errorf("status %v", lp.status) } if lp.charging() { t.Errorf("charging %v", lp.charging()) } } func TestUpdatePowerZero(t *testing.T) { tc := []struct { status api.ChargeStatus mode api.ChargeMode expect func(h *mock.MockCharger) }{ {api.StatusA, api.ModeOff, func(h *mock.MockCharger) { h.EXPECT().Enable(false) }}, {api.StatusA, api.ModeNow, func(h *mock.MockCharger) { h.EXPECT().Enable(false) }}, {api.StatusA, api.ModeMinPV, func(h *mock.MockCharger) { h.EXPECT().Enable(false) }}, {api.StatusA, api.ModePV, func(h *mock.MockCharger) { h.EXPECT().Enable(false) // zero since update called with 0 }}, {api.StatusB, api.ModeOff, func(h *mock.MockCharger) { h.EXPECT().Enable(false) }}, {api.StatusB, api.ModeNow, func(h *mock.MockCharger) { h.EXPECT().MaxCurrent(int64(maxA)) // true }}, {api.StatusB, api.ModeMinPV, func(h *mock.MockCharger) { // MaxCurrent omitted since identical value }}, {api.StatusB, api.ModePV, func(h *mock.MockCharger) { // zero since update called with 0 // force = false due to pv mode climater check h.EXPECT().Enable(false) }}, {api.StatusC, api.ModeOff, func(h *mock.MockCharger) { h.EXPECT().Enable(false) }}, {api.StatusC, api.ModeNow, func(h *mock.MockCharger) { h.EXPECT().MaxCurrent(int64(maxA)) // true }}, {api.StatusC, api.ModeMinPV, func(h *mock.MockCharger) { // MaxCurrent omitted since identical value }}, {api.StatusC, api.ModePV, func(h *mock.MockCharger) { // omitted since PV balanced }}, } for _, tc := range tc { t.Log(tc) clck := clock.NewMock() ctrl := gomock.NewController(t) charger := mock.NewMockCharger(ctrl) lp := &Loadpoint{ log: util.NewLogger("foo"), bus: evbus.New(), clock: clck, charger: charger, chargeMeter: &Null{}, // silence nil panics chargeRater: &Null{}, // silence nil panics chargeTimer: &Null{}, // silence nil panics wakeUpTimer: NewTimer(), MinCurrent: minA, MaxCurrent: maxA, phases: 1, status: tc.status, // no status change } attachListeners(t, lp) // initial status charger.EXPECT().Status().Return(tc.status, nil) charger.EXPECT().Enabled().Return(true, nil) if tc.expect != nil { tc.expect(charger) } lp.Mode = tc.mode lp.Update(0, false, false) // sitePower false,0 ctrl.Finish() } } func TestPVHysteresis(t *testing.T) { const dt = time.Minute const phases = 3 type se struct { site float64 delay time.Duration // test case delay since start current float64 } tc := []struct { enabled bool enable, disable float64 series []se }{ // keep disabled {false, 0, 0, []se{ {0, 0, 0}, {0, 1, 0}, {0, dt - 1, 0}, {0, dt + 1, 0}, }}, // enable when threshold not configured but min power met {false, 0, 0, []se{ {-6 * 100 * phases, 0, 0}, {-6 * 100 * phases, 1, 0}, {-6 * 100 * phases, dt - 1, 0}, {-6 * 100 * phases, dt + 1, minA}, }}, // keep disabled when threshold not configured {false, 0, 0, []se{ {-400, 0, 0}, {-400, 1, 0}, {-400, dt - 1, 0}, {-400, dt + 1, 0}, }}, // keep disabled when threshold (lower minCurrent) not met {false, -500, 0, []se{ {-400, 0, 0}, {-400, 1, 0}, {-400, dt - 1, 0}, {-400, dt + 1, 0}, }}, // keep disabled when threshold (higher minCurrent) not met {false, -7 * 100 * phases, 0, []se{ {-6 * 100 * phases, 0, 0}, {-6 * 100 * phases, 1, 0}, {-6 * 100 * phases, dt - 1, 0}, {-6 * 100 * phases, dt + 1, 0}, }}, // enable when threshold met {false, -500, 0, []se{ {-500, 0, 0}, {-500, 1, 0}, {-500, dt - 1, 0}, {-500, dt + 1, minA}, }}, // keep enabled at max {true, 500, 0, []se{ {-16 * 100 * phases, 0, maxA}, {-16 * 100 * phases, 1, maxA}, {-16 * 100 * phases, dt - 1, maxA}, {-16 * 100 * phases, dt + 1, maxA}, }}, // keep enabled at min {true, 500, 0, []se{ {-6 * 100 * phases, 0, minA}, {-6 * 100 * phases, 1, minA}, {-6 * 100 * phases, dt - 1, minA}, {-6 * 100 * phases, dt + 1, minA}, }}, // keep enabled at min (negative threshold) {true, 0, 500, []se{ {-500, 0, minA}, {-500, 1, minA}, {-500, dt - 1, minA}, {-500, dt + 1, minA}, }}, // disable when threshold met {true, 0, 500, []se{ {500, 0, minA}, {500, 1, minA}, {500, dt - 1, minA}, {500, dt + 1, 0}, }}, // reset enable timer when threshold not met while timer active {false, -500, 0, []se{ {-500, 0, 0}, {-500, 1, 0}, {-499, dt - 1, 0}, // should reset timer {-500, dt + 1, 0}, // new begin of timer {-500, 2 * dt, 0}, {-500, 2*dt + 1, minA}, }}, // reset enable timer when threshold not met while timer active and threshold not configured {false, 0, 0, []se{ {-6*100*10 - 1, dt + 1, 0}, {-6 * 100 * phases, dt + 1, 0}, {-6 * 100 * phases, dt + 2, 0}, {-6 * 100 * phases, 2 * dt, 0}, {-6 * 100 * phases, 2*dt + 1, minA}, }}, // reset disable timer when threshold not met while timer active {true, 0, 500, []se{ {500, 0, minA}, {500, 1, minA}, {499, dt - 1, minA}, // reset timer {500, dt + 1, minA}, // within reset timer duration {500, 2 * dt, minA}, // still within reset timer duration {500, 2*dt + 1, 0}, // reset timer elapsed }}, } for _, status := range []api.ChargeStatus{api.StatusB, api.StatusC} { for _, tc := range tc { t.Log(tc) clck := clock.NewMock() ctrl := gomock.NewController(t) charger := mock.NewMockCharger(ctrl) Voltage = 100 lp := &Loadpoint{ log: util.NewLogger("foo"), clock: clck, charger: charger, MinCurrent: minA, MaxCurrent: maxA, phases: phases, measuredPhases: phases, Enable: ThresholdConfig{ Threshold: tc.enable, Delay: dt, }, Disable: ThresholdConfig{ Threshold: tc.disable, Delay: dt, }, } // charging, otherwise PV mode logic is short-circuited lp.status = status start := clck.Now() for step, se := range tc.series { clck.Set(start.Add(se.delay)) // maxCurrent will read actual current and enabled state in PV mode // charger.EXPECT().Enabled().Return(tc.enabled, nil) lp.enabled = tc.enabled current := lp.pvMaxCurrent(api.ModePV, se.site, false) if current != se.current { t.Errorf("step %d: wanted %.1f, got %.1f", step, se.current, current) } } ctrl.Finish() } } } func TestPVHysteresisForStatusOtherThanC(t *testing.T) { const phases = 3 clck := clock.NewMock() ctrl := gomock.NewController(t) Voltage = 100 lp := &Loadpoint{ log: util.NewLogger("foo"), clock: clck, MinCurrent: minA, MaxCurrent: maxA, phases: phases, measuredPhases: phases, } // not connected, test PV mode logic short-circuited lp.status = api.StatusA // maxCurrent will read enabled state in PV mode sitePower := -float64(phases)*minA*Voltage + 1 // 1W below min power current := lp.pvMaxCurrent(api.ModePV, sitePower, false) if current != 0 { t.Errorf("PV mode could not disable charger as expected. Expected 0, got %.f", current) } ctrl.Finish() } func TestDisableAndEnableAtTargetSoc(t *testing.T) { clock := clock.NewMock() ctrl := gomock.NewController(t) charger := mock.NewMockCharger(ctrl) vehicle := mock.NewMockVehicle(ctrl) // wrap vehicle with estimator vehicle.EXPECT().Capacity().Return(float64(10)) vehicle.EXPECT().Phases().Return(0).AnyTimes() socEstimator := soc.NewEstimator(util.NewLogger("foo"), charger, vehicle, false) lp := &Loadpoint{ log: util.NewLogger("foo"), bus: evbus.New(), clock: clock, charger: charger, chargeMeter: &Null{}, // silence nil panics chargeRater: &Null{}, // silence nil panics chargeTimer: &Null{}, // silence nil panics progress: NewProgress(0, 10), // silence nil panics wakeUpTimer: NewTimer(), // silence nil panics // coordinator: coordinator.NewDummy(), // silence nil panics MinCurrent: minA, MaxCurrent: maxA, vehicle: vehicle, // needed for targetSoc check socEstimator: socEstimator, // instead of vehicle: vehicle, Mode: api.ModeNow, Soc: SocConfig{ target: 90, Poll: PollConfig{ Mode: pollConnected, // allow polling when connected Interval: pollInterval, }, }, } attachListeners(t, lp) lp.enabled = true lp.chargeCurrent = float64(minA) lp.status = api.StatusC t.Log("charging below soc target") vehicle.EXPECT().Soc().Return(85.0, nil) charger.EXPECT().Status().Return(api.StatusC, nil) charger.EXPECT().Enabled().Return(lp.enabled, nil) charger.EXPECT().MaxCurrent(int64(maxA)).Return(nil) lp.Update(500, false, false) t.Log("charging above target - soc deactivates charger") clock.Add(5 * time.Minute) vehicle.EXPECT().Soc().Return(90.0, nil) charger.EXPECT().Status().Return(api.StatusC, nil) charger.EXPECT().Enabled().Return(lp.enabled, nil) charger.EXPECT().Enable(false).Return(nil) lp.Update(500, false, false) t.Log("deactivated charger changes status to B") clock.Add(5 * time.Minute) vehicle.EXPECT().Soc().Return(95.0, nil) charger.EXPECT().Status().Return(api.StatusB, nil) charger.EXPECT().Enabled().Return(lp.enabled, nil) lp.Update(-5000, false, false) t.Log("soc has fallen below target - soc update prevented by timer") clock.Add(5 * time.Minute) charger.EXPECT().Status().Return(api.StatusB, nil) charger.EXPECT().Enabled().Return(lp.enabled, nil) lp.Update(-5000, false, false) t.Log("soc has fallen below target - soc update timer expired") clock.Add(pollInterval) vehicle.EXPECT().Soc().Return(85.0, nil) charger.EXPECT().Status().Return(api.StatusB, nil) charger.EXPECT().Enabled().Return(lp.enabled, nil) charger.EXPECT().Enable(true).Return(nil) lp.Update(-5000, false, false) ctrl.Finish() } func TestSetModeAndSocAtDisconnect(t *testing.T) { clock := clock.NewMock() ctrl := gomock.NewController(t) charger := mock.NewMockCharger(ctrl) lp := &Loadpoint{ log: util.NewLogger("foo"), bus: evbus.New(), clock: clock, charger: charger, chargeMeter: &Null{}, // silence nil panics chargeRater: &Null{}, // silence nil panics chargeTimer: &Null{}, // silence nil panics wakeUpTimer: NewTimer(), MinCurrent: minA, MaxCurrent: maxA, status: api.StatusC, Mode: api.ModeOff, Soc: SocConfig{ target: 70, }, ResetOnDisconnect: true, } attachListeners(t, lp) lp.collectDefaults() lp.enabled = true lp.chargeCurrent = float64(minA) lp.Mode = api.ModeNow t.Log("charging at min") charger.EXPECT().Enabled().Return(lp.enabled, nil) charger.EXPECT().Status().Return(api.StatusC, nil) charger.EXPECT().MaxCurrent(int64(maxA)).Return(nil) lp.Update(500, false, false) t.Log("switch off when disconnected") clock.Add(5 * time.Minute) charger.EXPECT().Enabled().Return(lp.enabled, nil) charger.EXPECT().Status().Return(api.StatusA, nil) charger.EXPECT().Enable(false).Return(nil) lp.Update(-3000, false, false) if lp.Mode != api.ModeOff { t.Error("unexpected mode", lp.Mode) } ctrl.Finish() } // cacheExpecter can be used to verify asynchronously written values from cache func cacheExpecter(t *testing.T, lp *Loadpoint) (*util.Cache, func(key string, val interface{})) { // attach cache for verifying values paramC := make(chan util.Param) lp.uiChan = paramC cache := util.NewCache() go cache.Run(paramC) expect := func(key string, val interface{}) { p := cache.Get(key) t.Logf("%s: %.f", key, p.Val) // REMOVE if p.Val != val { t.Errorf("%s wanted: %.0f, got %v", key, val, p.Val) } } return cache, expect } func TestChargedEnergyAtDisconnect(t *testing.T) { clock := clock.NewMock() ctrl := gomock.NewController(t) charger := mock.NewMockCharger(ctrl) rater := mock.NewMockChargeRater(ctrl) lp := &Loadpoint{ log: util.NewLogger("foo"), bus: evbus.New(), clock: clock, charger: charger, chargeMeter: &Null{}, // silence nil panics chargeRater: rater, chargeTimer: &Null{}, // silence nil panics wakeUpTimer: NewTimer(), MinCurrent: minA, MaxCurrent: maxA, status: api.StatusC, } attachListeners(t, lp) lp.enabled = true lp.chargeCurrent = float64(maxA) lp.Mode = api.ModeNow // attach cache for verifying values _, expectCache := cacheExpecter(t, lp) t.Log("start charging at 0 kWh") rater.EXPECT().ChargedEnergy().Return(0.0, nil) charger.EXPECT().Enabled().Return(lp.enabled, nil) charger.EXPECT().Status().Return(api.StatusC, nil) lp.Update(-1, false, false) t.Log("at 1:00h charging at 5 kWh") clock.Add(time.Hour) rater.EXPECT().ChargedEnergy().Return(5.0, nil) charger.EXPECT().Enabled().Return(lp.enabled, nil) charger.EXPECT().Status().Return(api.StatusC, nil) lp.Update(-1, false, false) expectCache("chargedEnergy", 5000.0) t.Log("at 1:00h stop charging at 5 kWh") clock.Add(time.Second) rater.EXPECT().ChargedEnergy().Return(5.0, nil) charger.EXPECT().Enabled().Return(lp.enabled, nil) charger.EXPECT().Status().Return(api.StatusB, nil) lp.Update(-1, false, false) expectCache("chargedEnergy", 5000.0) t.Log("at 1:00h restart charging at 5 kWh") clock.Add(time.Second) rater.EXPECT().ChargedEnergy().Return(5.0, nil) charger.EXPECT().Enabled().Return(lp.enabled, nil) charger.EXPECT().Status().Return(api.StatusC, nil) lp.Update(-1, false, false) expectCache("chargedEnergy", 5000.0) t.Log("at 1:30h continue charging at 7.5 kWh") clock.Add(30 * time.Minute) rater.EXPECT().ChargedEnergy().Return(7.5, nil) charger.EXPECT().Enabled().Return(lp.enabled, nil) charger.EXPECT().Status().Return(api.StatusC, nil) lp.Update(-1, false, false) expectCache("chargedEnergy", 7500.0) t.Log("at 2:00h stop charging at 10 kWh") clock.Add(30 * time.Minute) rater.EXPECT().ChargedEnergy().Return(10.0, nil) charger.EXPECT().Enabled().Return(lp.enabled, nil) charger.EXPECT().Status().Return(api.StatusB, nil) lp.Update(-1, false, false) expectCache("chargedEnergy", 10000.0) ctrl.Finish() } func TestTargetSoc(t *testing.T) { ctrl := gomock.NewController(t) vhc := mock.NewMockVehicle(ctrl) tc := []struct { vehicle api.Vehicle target int soc float64 res bool }{ {nil, 0, 0, false}, // never reached without vehicle {nil, 0, 10, false}, // never reached without vehicle {nil, 80, 0, false}, // never reached without vehicle {nil, 80, 80, false}, // never reached without vehicle {nil, 80, 100, false}, // never reached without vehicle {vhc, 0, 0, false}, // target disabled {vhc, 0, 10, false}, // target disabled {vhc, 80, 0, false}, // target not reached {vhc, 80, 80, true}, // target reached {vhc, 80, 100, true}, // target reached {vhc, 100, 100, false}, // target reached, let ev control deactivation } for _, tc := range tc { t.Logf("%+v", tc) lp := &Loadpoint{ vehicle: tc.vehicle, Soc: SocConfig{ target: tc.target, }, vehicleSoc: tc.soc, } if res := lp.targetSocReached(); tc.res != res { t.Errorf("expected %v, got %v", tc.res, res) } } } func TestSocPoll(t *testing.T) { clock := clock.NewMock() tRefresh := pollInterval tNoRefresh := pollInterval / 2 lp := &Loadpoint{ clock: clock, log: util.NewLogger("foo"), Soc: SocConfig{ Poll: PollConfig{ Interval: time.Hour, }, }, } tc := []struct { mode string status api.ChargeStatus dt time.Duration res bool }{ // pollCharging {pollCharging, api.StatusA, -1, false}, {pollCharging, api.StatusA, 0, false}, {pollCharging, api.StatusA, tRefresh, false}, {pollCharging, api.StatusB, -1, true}, // poll once when car connected {pollCharging, api.StatusB, 0, false}, {pollCharging, api.StatusB, tRefresh, false}, {pollCharging, api.StatusC, -1, true}, {pollCharging, api.StatusC, 0, true}, {pollCharging, api.StatusC, tNoRefresh, true}, // cached by vehicle {pollCharging, api.StatusC, tRefresh, true}, // will set lp.didChargeOnLastSocUpdate {pollCharging, api.StatusB, 0, false}, // last update must wait for interval {pollCharging, api.StatusB, tRefresh, true}, // update once if connected and was charging {pollCharging, api.StatusB, tRefresh, false}, // but only once // pollConnected {pollConnected, api.StatusA, -1, false}, {pollConnected, api.StatusA, 0, false}, {pollConnected, api.StatusA, tRefresh, false}, {pollConnected, api.StatusB, -1, true}, {pollConnected, api.StatusB, 0, false}, {pollConnected, api.StatusB, tNoRefresh, false}, {pollConnected, api.StatusB, tRefresh, true}, {pollConnected, api.StatusC, -1, true}, {pollConnected, api.StatusC, 0, true}, {pollConnected, api.StatusC, tNoRefresh, true}, // cached by vehicle {pollConnected, api.StatusC, tRefresh, true}, // pollAlways {pollAlways, api.StatusA, -1, true}, {pollAlways, api.StatusA, 0, false}, {pollAlways, api.StatusA, tNoRefresh, false}, {pollAlways, api.StatusA, tRefresh, true}, {pollAlways, api.StatusB, -1, true}, {pollAlways, api.StatusB, 0, false}, {pollAlways, api.StatusB, tNoRefresh, false}, {pollAlways, api.StatusB, tRefresh, true}, {pollAlways, api.StatusC, -1, true}, {pollAlways, api.StatusC, 0, true}, {pollAlways, api.StatusC, tNoRefresh, true}, // cached by vehicle {pollAlways, api.StatusC, tRefresh, true}, } for _, tc := range tc { t.Logf("%+v", tc) if tc.dt < 0 { lp.socUpdated = time.Time{} } else { clock.Add(tc.dt) } lp.Soc.Poll.Mode = tc.mode lp.status = tc.status res := lp.vehicleSocPollAllowed() if res { // mimic update outside of socPollAllowed lp.socUpdated = clock.Now() } if tc.res != res { t.Errorf("expected %v, got %v", tc.res, res) } } } func TestMinSoc(t *testing.T) { ctrl := gomock.NewController(t) vhc := mock.NewMockVehicle(ctrl) tc := []struct { vehicle *mock.MockVehicle min int soc float64 energy float64 res bool }{ {nil, 0, 0, 0, false}, // never reached without vehicle {nil, 0, 10, 0, false}, // never reached without vehicle {nil, 80, 0, 0, false}, // never reached without vehicle {nil, 80, 80, 0, false}, // never reached without vehicle {nil, 80, 100, 0, false}, // never reached without vehicle {vhc, 0, 0, 0, false}, // min disabled {vhc, 0, 10, 0, false}, // min disabled {vhc, 80, 0, 0, true}, // min not reached {vhc, 80, 10, 0, true}, // min not reached {vhc, 80, 0, 8.0, true}, // min energy not reached {vhc, 80, 0, 9.0, false}, // min energy reached {vhc, 80, 80, 0, false}, // min reached {vhc, 80, 100, 0, false}, // min reached } for _, tc := range tc { lp := &Loadpoint{ Soc: SocConfig{ min: tc.min, }, vehicleSoc: tc.soc, chargedEnergy: tc.energy, } if v := tc.vehicle; v != nil { lp.vehicle = tc.vehicle // avoid assigning nil to interface v.EXPECT().Capacity().Return(10.0).MaxTimes(1) } assert.Equal(t, tc.res, lp.minSocNotReached(), tc) } }